Floran Speech Revert #6453
Floran Speech Revert #6453
Conversation
Attempting to revert the Floran speech changes that happened a while ago (around when Ornithids got added)
|
You know, I really hope this isn't a stupid PR, I never really have used github. I only know basic coding stuff, so I'm SURE there will be something wrong with how I did this, but hopefully my idea gets across and it can be properly implemented by someone that knows what they're doing! Also, not sure if this will implement the hiss length variable like is available on character creation for lizards. |
|
Personally, I would say that the speech modification proc be it's own proc to be used across the codebase, but the polyglot tongue has most of it's conversion/modification stuff in one big proc too, so I think this is fine until someone turns each of the speech modifications in to their own global proc. |
flleeppyy
added
the
Approval: awaiting admin review
|
|
|
I think I fixed the oopsie, there was no client side way to set hiss length so it depended on random map generation. Now it should hopefully pop up during character creation for florans, so you can set just how much you want to hiss. |
|
I am very, very sorry that I am not good at this. This time it should be working, hopefully. |
Veth-s
added
Approval: admin approved
About The Pull Request
This pull request should bring Floran speech back in line with how lizard speech works, primarily re-implementing hissing. I am not a coder, but this bugged me for a little while and felt too small to list as an issue. I figured I would give it a shot myself, so hopefully it works.
Why It's Good For The Game
In their source material, Starbound, florans have trouble saying the "s" sound, drawing it out heavily. It's one of the fun quirks of their speech, so I was a bit disappointed when suddenly it was gone from monke and replaced with the speech prefix "whistles," which just doesn't really fit the savage plant people all that well.
Changelog
🆑
changed: floran speech from "whistles" to "hisses."
code: copied draw_length and other logic from lizard tongues to floran tongues
/:cl: